Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does caronte require Node 0.10? #474

Closed
glasser opened this issue Sep 16, 2013 · 1 comment
Closed

Does caronte require Node 0.10? #474

glasser opened this issue Sep 16, 2013 · 1 comment

Comments

@glasser
Copy link
Contributor

glasser commented Sep 16, 2013

I see, eg, that the ws-incoming stream pass calls unshift on a socket, which I believe is a new method as of streams2. Since the package.json doesn't use the backwards-compatibility readable-stream package, that makes me think that caronte is not intended to support Node 0.8.

That's probably a reasonable decision to make, but could it be documented explicitly, in the README.md and/or the engines field of package.json?

yawnt added a commit that referenced this issue Sep 16, 2013
@yawnt yawnt closed this as completed Sep 16, 2013
@yawnt
Copy link
Contributor

yawnt commented Sep 16, 2013

i added that to package.json .. thanks for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants