Close the connection when target sends "Connection: close" header #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 4, 2016 17:35
This prevents ECONNRESET errors from being thrown for connections that are supposed to be closed (fixes http-party#1000).
Don't immediately close the response socket when a `Connection: close` header is received from the target. Instead simply skip the error callback for connection errors on sockets that are supposed to be closed.
|
The initial change caused some connections to be closed before all data was transmitted to the client. I changed it so that instead of closing connections, connection errors for connections that are supposed to be closed don't trigger the error callback. |
Merge upstream
| @@ -137,6 +137,12 @@ web_o = Object.keys(web_o).map(function(pass) { | |||
| proxyReq.on('error', proxyError); | |||
|
|
|||
| function proxyError (err){ | |||
| if (err.code === 'ECONNRESET' && proxyReq._headers && proxyReq._headers.connection === 'close') { | |||
There was a problem hiding this comment.
im about to merge the case with the econnreset throwing errors that arent really errors. you should rebase all that and try and get the tests to pass and ill consider the use case here.
|
Seems to have been fixed by #966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents ECONNRESET errors from being thrown for connections
that are supposed to be closed (fixes #1000).