Revert writeHeaders method and add preserveHeaderKeyCase option #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pachirel
force-pushed
the
use-header-key-only
branch
from
7b25e2b
to
37916f9
Compare
|
@pachirel ill push this out now, submit a follow up PR with any additional changes you wanted to make so we can get this fixed. |
|
Sure 👍
|
pachirel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My change (#1098) has side effect because of the header values of
rawHeadersare not always same with the values ofheaders. ( #1101, #1102, #1103) 🙇This PR includes these changes to solve it:
preserveHeaderKeyCaseoption (default: false).@jcrugzz I'd like to hear your thought. 🍣
I have to add specs before marge this.
Sorry for any inconvenience, and thanks to all.