Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update options.changeOrigin description in docs #1130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asvae
Copy link

@asvae asvae commented Jan 9, 2017

changeOrigin has nothing to do with origin header which is confusing and harmful when working with CORS. As CORS middleware sometimes makes decisions depending on origin header.

changeOrigin option handles solely host header.

changeOrigin has nothing to do with `origin` header which is confusing and harmful when working with CORS. As CORS middleware sometimes makes decisions depending on `origin` header.

`changeOrigin` option handles solely `host` header.
@patrickallaert
Copy link

Correct, but in my opinion, the changeOrigin config should just be removed and default to true. See #1132 for more info.

@johnhunter
Copy link

While discussion on removing changeOrigin continues, can we not update the docs to clarify what the setting actually does?

It does not change the origin header but consuming projects assume it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants