prefer target.hostname
over target.host
#235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I struggled to debug an
Error: getaddrinfo ENOENT
.I parsed my target string with
url
And pass this object to
node-http-proxy
.Then the following code is executed :
But host === '127.0.0.1:3000', and it fails.
That's why I would prefer
because hostname always === '127.0.0.1'
This is also a nodejs recommendation:
http://nodejs.org/api/http.html#http_http_request_options_callback