Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The number of maxSockets has to be set after the agent is created. Settin #84

Merged
merged 1 commit into from
Aug 2, 2011
Merged

Conversation

KimSchneider
Copy link
Contributor

The number of maxSockets has to be set after the agent is created. Setting the property in the constructor does not work.

…tting the property in the constructor does not work.
@jamesonjlee
Copy link

this is actually is a feature of node.js core.

https://github.com/joyent/node/blob/v0.4.10/lib/http.js#L1139-1147

unless this is something that would be useful? @dominictarr

@dominictarr
Copy link
Contributor

am yet to confirm the bug this commit fixes. see discussion here: #80

@bluescreen303
Copy link

Just ran into this issue
I used setMaxSockets, but all agents report their default (5) instead.
Indeed, it appears the Agent constructor doesn't look at the maxConnections option, but rather uses the global Agent.defaultMaxSockets
So if http-proxy wants to set this, it has to occur after calling the Agent constructor.

@dominictarr dominictarr merged commit 2caa5d2 into http-party:master Aug 2, 2011
@dominictarr
Copy link
Contributor

you where right,

thanks!

@indexzero
Copy link
Contributor

@DrJackal @KimSchneider is actually correct here. @dominictarr +1 to merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants