resolves #882 #883
resolves #882 #883
Conversation
Adds a proxyWsReq event that can be used to modify the outgoing websocket handshake.
| var proxyServer = http.createServer(requestHandler); | ||
|
|
||
| proxyServer.on('upgrade', function(req, res, head){ | ||
| proxy.ws(req, res, head); |
|
Thank you for your contribution. I am +1 on this once the minor style things are addressed. |
Fixes style issues w/ original http-party#882 additions.
|
Style issues addressed. The last change require changing the previous 'var httpProxy' to 'var wsPasses'. Name chosen after seeing the 'var webPasses' for the similar include in the web tests. |
|
If there is anything else you need done before this is accepted; let me know. |
|
When is the next release scheduled? |
|
stylistically it looks good. i'm not familiar with this websocket handshake that takes place the test does show that its able to listen to that proxyres event and add the header tho, and it looks like the destination/source is able to receive that header |
|
@donasaur it's actually not about the Websocket handshake itself. It is mirroring similar @jcrugzz thoughts? |
|
ah ok @indexzero , actually it looks like jarrett already merged in a similar PR already: can you double check? |
Adds a proxyWsReq event that can be used to modify the outgoing
websocket handshake.