Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated markdown docs to mention proxy rules module #910

Merged
merged 1 commit into from
Nov 22, 2015

Conversation

donasaur
Copy link
Contributor

No description provided.

@indexzero
Copy link
Contributor

@donasaur could you add some code samples as well? I think that will help a lot of users better understand what they are getting from proxy-rules.

Related: we should do a pass at updating the README.md sometime in the next few cycles. For starters: a Table of Contents that highlights this feature more prevalently would help a lot of users as well.

@donasaur
Copy link
Contributor Author

Sure. For the former, should I do something like list a more readable version of these tests on the proxy-rules README?

@indexzero
Copy link
Contributor

@donasaur yeah that sounds good.

@donasaur
Copy link
Contributor Author

@indexzero Kk, I updated the README with a link to the relevant portion of the test, and made that portion readable with comments and a little name refactoring. See here

@jcrugzz
Copy link
Contributor

jcrugzz commented Nov 22, 2015

Looks good 👍. I agree this readme could use another walk through and have a proper table of contents. Good next steps

jcrugzz added a commit that referenced this pull request Nov 22, 2015
Updated markdown docs to mention proxy rules module
@jcrugzz jcrugzz merged commit 642e9cc into master Nov 22, 2015
@jcrugzz jcrugzz deleted the proxy-table-readme branch November 22, 2015 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants