Don't bail when os.networkInterfaces is not supported. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of non-supported operation under Windows Subsystem for Linux os.networkInterfaces(), line 395, throws a not supported error on WSL (bash for windows). The operation will be supported at some point, but for now, I would want it to not crash and just return default values.
I promise, I can javascript.
|
Relevant WSL issue: microsoft/WSL#468 You may just wait until it is resolved in WSL itself, as a fix is in progress. Felt like there should be some documentation in place. |
|
@kayakyakr - thanks for the PR - let me try this out as well |
eriktrom
added a commit
that referenced
this pull request
Oct 17, 2016
- Windows 10 native shell(#39) was rebinding to already bound ports. We now send a message from a socket client -> server -> client to ensure a host + port are actually open - Windows 10 bash shell falls back to using 0.0.0.0 as the only host we check in order to prevent throwing a syscall error as being tracked here: microsoft/WSL#468 fixes: #39 closes: #41 fixes: ember-cli/ember-cli#6338
Merged
|
Thanks again @kayakyakr - I integrated your changes into #42 (along with changes for windows 10 native shell) |
|
@kayakyakr - thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of non-supported operation under Windows Subsystem for Linux
os.networkInterfaces(), line 395, throws a not supported error on WSL (bash for windows).
The operation will be supported at some point, but for now, I would want it to not crash and just return default values.