Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please document the MSRV for async-h1 #113

Closed
rbtcollins opened this issue May 26, 2020 · 1 comment · Fixed by #118
Closed

Please document the MSRV for async-h1 #113

rbtcollins opened this issue May 26, 2020 · 1 comment · Fixed by #118

Comments

@rbtcollins
Copy link

I used async-std and surf in unleash-client-rust recently, and trying to document the minimum supported rust version for it is turning out harder than expected ;(. async-h1 seems to be using latest-everything features - and thats probably fine, async is new etc, but it would be nice to know what the actual policy is going forward. Just a one liner in README.md.

Thanks!

(rust-lang/rust#65721 is what caught me trying to make 1.40 the MSRV, which is used by async-h1).

@yoshuawuyts
Copy link
Member

This is an interesting one -- I have no objections to documenting the MSRV but given the nature of async in Rust right now I would like us to reserve the option to bump the minimum version without publishing a major. In effect the stability guarantee we provide is that we work on stable Rust.

yoshuawuyts added a commit that referenced this issue May 29, 2020
@jbr jbr closed this as completed in #118 Jul 14, 2020
jbr pushed a commit that referenced this issue Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants