deps: replace async-std with futures-lite #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of using the |
|
Will do, I was originally going to use futures-lite but it's always hard to know at the moment which stacks are preferable where! :-) |
raggi
changed the title
|
I moved it over to futures-lite. PTAL, and thank you! |
erickt
reviewed
Apr 13, 2021
It may be useful to be able to use this in more ecosystems without taking the whole async-std dependency. The async-std dependency was mostly through re-exports that can instead be taken directly on the futures crate.
|
Are there any outstanding issues before this can be merged? Would love to use this crate for a project but definitely don't want to pull in async-std. |
yoshuawuyts
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be useful to be able to use this in more ecosystems without
taking the whole async-std dependency. The async-std dependency was
mostly through re-exports that can instead be taken directly on the
futures crate.