Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for passing preconfigured isahc HttpClient instance. #19

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Add support for passing preconfigured isahc HttpClient instance. #19

merged 1 commit into from
Jan 27, 2020

Conversation

alex-berger
Copy link

This PR adds support to create an IsahcClient instance from a preconfigured iashc::HttpClient instance. This is important if one needs to tweak the client configuration.

yoshuawuyts
yoshuawuyts approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is nice!

@yoshuawuyts
Copy link
Member

CI seems to have failed; re-running.

@yoshuawuyts yoshuawuyts merged commit 98359bf into http-rs:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-berger @yoshuawuyts