Add more From conversions #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These look quite convenient! |
|
@jbr done! |
jbr
reviewed
Apr 22, 2020
| let mut res = Response::new(StatusCode::Ok); | ||
| res.set_body(b); | ||
| res.set_body(body); |
There was a problem hiding this comment.
This is a minor tweak, but this could be
impl<T> From<T> for Response
where
T: Into<Body>,
{
fn from(value: T) -> Self {
let mut res = Response::new(StatusCode::Ok);
res.set_body(value);
res
}
}since replace_body does the .into::<Body>()
meta: is this sort of review useful?
There was a problem hiding this comment.
@jbr thanks heaps for suggesting this; yeah this is very useful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we couldn't use
Into<Response>in Tide's Endpoints because of the orphan rules. Tide now uses its ownResponseso we can move to deprecate that trait.This patch adds the missing conversions currently used in Tide (src). This will make it easier to implement the conversions in Tide as well. Thanks!