Add feature for enabling signed and encrypted cookie support #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cookie crate uses the ring crate's HMAC module to implement signed cookies and its AEAD module for authenticated encrypted cookies. Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
|
(Turns out that cookie 0.14.0 will use the RustCrypto crates instead of ring, though the CookieJar interface appears to be unchanged.) |
yoshuawuyts
approved these changes
May 29, 2020
There was a problem hiding this comment.
Thanks so much; this LGTM -- though just like in http-rs/tide#541 (review) I'm open to the idea of enabling this by default, and making secure cookie support opt-out rather than opt-in.
|
Sure, I can file another PR adding it to the default feature as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cookie crate uses the ring crate's HMAC module to implement signed
cookies and its AEAD module for authenticated encrypted cookies.