Status should take TryInto<StatusCode> #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 25, 2020 09:05
Change the trait bound of S to accept a TryInto<StatusCode>; this would allow the Status trait to accept a wider range of input. Change the trait bound for 'status'. Refs: #155
Change the trait bound of S to accept a TryInto<StatusCode>; this would allow the Status trait to accept a wider range of input. Change the trait bound for 'with_status'. Refs: #155
|
The commit a2e58a1 contains only the linting from Thanks |
yoshuawuyts
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the trait bound of
Sin theStatustrait to accept aTryInto<StatusCode>; this would allow theStatustrait to accept a wider range of input.Uses the same approach as
Response::new.Refs: #155
Draft PR until the checklist is complete: