Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trailers methods #176

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Fix trailers methods #176

merged 1 commit into from
Jun 9, 2020

Conversation

yoshuawuyts
Copy link
Member

This fixes some issues around trailers which are required to implement trailers support for async-h1. Given the current state of the API is not particularly usable I'm fairly certain nobody is using this and we can safely issue a fix.

Changes

  • Added {Request,Response}::has_trailers methods
  • Fixed {Request,Response}::recv_trailers which were incorrectly marked as async fn

Fishrock123
Fishrock123 requested changes Jun 7, 2020
View reviewed changes
Copy link
Member

@Fishrock123 Fishrock123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request::send_trailers() should set self.has_trailers.

Although maybe, either the bool should be better named (sent_trailers?), or storage of any trailers should be an Option<>?

@yoshuawuyts yoshuawuyts merged commit 0836aa5 into master Jun 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the patch-trailers branch June 9, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshuawuyts @Fishrock123