Add content::AcceptEncoding.
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
previously requested changes
Aug 24, 2020
Fishrock123
reviewed
Aug 24, 2020
There was a problem hiding this comment.
Some more comments.
This is stuff I came across while making a wip swap to this for tide-compress which is at Fishrock123/tide-compress@dff0747
yoshuawuyts
force-pushed
the
accept-encoding
branch
from
fff2884
to
5ea814f
Compare
yoshuawuyts
dismissed
Fishrock123’s stale review
Applied all feedback from review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #230, ref #99. Adds support for
Content-Encoding,Accept-Encodingand content negotiation to select the right encoding.The approach in this patch can likely be adapted to work for
TE,Accept-LanguageandAccept-Charsetas well.Screenshot