Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BasicAuth::from_credentials #284

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Add BasicAuth::from_credentials #284

merged 1 commit into from
Nov 25, 2020

Conversation

rossmacarthur
Copy link
Contributor

If you already have an Authorization instance this allows you to construct a BasicAuth using it without parsing an Authorization from the headers again.

yoshuawuyts
yoshuawuyts approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; thanks!

@yoshuawuyts yoshuawuyts merged commit 2a89da2 into http-rs:main Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossmacarthur @yoshuawuyts