Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Response doc-tests to actually use Response #76

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Fix Response doc-tests to actually use Response #76

merged 1 commit into from
Mar 3, 2020

Conversation

goto-bus-stop
Copy link
Member

Some of them were testing the methods from Request instead.

@goto-bus-stop
Fix Response doc-tests to actually use Response
ccb9460 
Some of them were testing the methods from `Request` instead.
yoshuawuyts
yoshuawuyts approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yes great catch. Thank you!

@yoshuawuyts yoshuawuyts merged commit 892b03b into master Mar 3, 2020
@yoshuawuyts yoshuawuyts deleted the really-use-response branch March 3, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goto-bus-stop @yoshuawuyts