Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Satisfy Clippy where ever possible #92

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Satisfy Clippy where ever possible #92

merged 2 commits into from
Apr 16, 2020

Conversation

Kestrer
Copy link
Contributor

@Kestrer Kestrer commented Apr 6, 2020

Changes include:

  • Adding is_empty methods as well as len methods.
  • Removing explicit lifetimes
  • Adding Default impls for Headers and Trailers
  • A few other minor changes that Clippy suggested.

I did not follow all the lints and make breaking changes.

yoshuawuyts
yoshuawuyts requested changes Apr 11, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these changes look really good; if we can omit the Default impls this should be good to merge!

src/trailers.rs Outdated Show resolved Hide resolved
src/headers/mod.rs Outdated Show resolved Hide resolved
@yoshuawuyts yoshuawuyts merged commit 403d5e2 into http-rs:master Apr 16, 2020
@ririsoft ririsoft mentioned this pull request Jun 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kestrer @yoshuawuyts