Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md missing #491

Closed
gcapizzi opened this issue May 9, 2020 · 2 comments
Closed

CONTRIBUTING.md missing #491

gcapizzi opened this issue May 9, 2020 · 2 comments

Comments

@gcapizzi
Copy link

gcapizzi commented May 9, 2020

Hey! 👋
I was very excited when I saw the README links to a CONTRIBUTING.md file, only to realise it's actually missing 🙁

It would be great to put it back (maybe we can dig it up from history?), but if we can't we should probably remove the link. Happy to PR either of those two things.

Thanks!
@dbofmmbt
Copy link

dbofmmbt commented Jun 25, 2020 •
edited
Loading

It looks related to PR #337. The issue #421 also informed about the problem. I think it's something important to restore, since the README has a Contributing section and references it.

dbofmmbt pushed a commit to dbofmmbt/tide that referenced this issue Jun 25, 2020
restore .github docs
03f8ce4 
On PR http-rs#337, the .github folder was deleted, including important
documents such as CONTRIBUTING and CODE_OF_CONDUCT.

It aims to solve http-rs#421 and http-rs#491
@dbofmmbt dbofmmbt mentioned this issue Jun 25, 2020
Merged
jbr pushed a commit that referenced this issue Jun 25, 2020
@jbr
restore .github docs
4723957 
On PR #337, the .github folder was deleted, including important
documents such as CONTRIBUTING and CODE_OF_CONDUCT.

It aims to solve #421 and #491
@dbofmmbt
Copy link

@jbr I guess this one could be closed now, since CONTRIBUTING.md was restored by #616 .

@jbr jbr closed this as completed Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbr @gcapizzi @dbofmmbt