Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for issue #278: works around Rust internal compiler error. #279

Merged
merged 4 commits into from
Jun 24, 2019

Conversation

realcr
Copy link
Contributor

@realcr realcr commented Jun 19, 2019

Description

Solves problem mentioned in issue #278.
Solution according to: rust-lang/rust#61579 (comment)

Motivation and Context

tide can not be compiled after nightly 2019-06-01. However, another rustc bug doesn't allow me to compile my project's code for rustc of version lower than 2019-06-15. Therefore I currently have no possible way of compiling my project.

How Has This Been Tested?

cargo test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@tirr-c tirr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump rustc version in .travis.yml and see if the tests pass!

tide-cookies/src/middleware.rs Show resolved Hide resolved
Copy link
Collaborator

@tirr-c tirr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, merging!

@tirr-c tirr-c merged commit e4fcb6c into http-rs:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants