Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http-service in tide-panic to match rest of crate #312

Closed
wants to merge 2 commits into from
Closed

Update http-service in tide-panic to match rest of crate #312

wants to merge 2 commits into from

Conversation

WSeegers
Copy link

@WSeegers WSeegers commented Aug 21, 2019 •
edited
Loading

Description

At the moment the tide example does not compile on nightly. Updating the version corrects this.

Motivation and Context

Closes #311

How Has This Been Tested?

Unit tests pass.
Example code is now compiling.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@WSeegers
Copy link
Author

WSeegers commented Aug 21, 2019 •
edited
Loading

Apologies, I missed the pull request that corrects this. #309

@WSeegers WSeegers closed this Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tide-panic http-server version incorrect
1 participant
@WSeegers