Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Method Not Allowed in the Router #388

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Add Method Not Allowed in the Router #388

merged 2 commits into from
Jan 30, 2020

Conversation

isgj
Copy link
Contributor

@isgj isgj commented Jan 19, 2020

When the same path is registered but with another method respond with 405 instead of 404

yoshuawuyts
yoshuawuyts approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is really good; all for better diagnostics!

Left a few nits, should be good to merge when addressed. Thanks so much for this!

src/router.rs Outdated Show resolved Hide resolved
src/router.rs Outdated Show resolved Hide resolved
src/router.rs Outdated Show resolved Hide resolved
@isgj
Copy link
Contributor Author

isgj commented Jan 27, 2020

Happy to hear that.

@yoshuawuyts yoshuawuyts merged commit 84aa8eb into http-rs:master Jan 30, 2020
@isgj isgj deleted the method-not-allowed branch January 31, 2020 10:56
@Gowee Gowee mentioned this pull request Nov 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isgj @yoshuawuyts