Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set local and peer addrs in tide #530

Merged
merged 2 commits into from
May 23, 2020

Conversation

jbr
Copy link
Member

@jbr jbr commented May 23, 2020

forgot to pr this before 0.9, sorry!

@jbr jbr force-pushed the populate-local-and-peer-addrs branch from 0ec656a to 3e2e84c Compare May 23, 2020 00:40
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could have a test?

@jbr jbr force-pushed the populate-local-and-peer-addrs branch from 18d1720 to d364a95 Compare May 23, 2020 01:04
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yoshuawuyts yoshuawuyts merged commit 62b828c into http-rs:master May 23, 2020
@jbr jbr deleted the populate-local-and-peer-addrs branch May 23, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants