Update docs from Request.local to Request.ext #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
May 25, 2020
yoshuawuyts
approved these changes
May 25, 2020
|
I added a commit to change the "local"/"global" state doc references since the first commit is trivial. Feel free to modify/discuss if needed. |
Fishrock123
reviewed
May 25, 2020
There was a problem hiding this comment.
There's some mismatch here between Response::ext and Request::ext. As far as I can tell, both have extensions.
In addition to the below - https://github.com/http-rs/tide/blob/master/src/request.rs#L231-L240
Merged
- Clarify "local"/"global" state to request/response/application scoped state
|
Rebased and squashed to one commit. If there's anything else, please feel free to leave a comment. |
yoshuawuyts
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method was renamed in Tide 0.9.
Just 2 cents, it was a bit confusing to me to use "local state" and "global state" as the names because IMHO those terms are normally associated with entire programs. Other frameworks call "local state" as "per request state" or "request scoped state". The "global state" is sometimes referred to as "application scoped state" as well. I'm not familiar with the design and terminology of this framework, but my suggestion would be to clarify/rename those concepts.