Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use query from http types #555

Merged
merged 2 commits into from
May 29, 2020
Merged

Use query from http types #555

merged 2 commits into from
May 29, 2020

Conversation

plippe
Copy link
Contributor

@plippe plippe commented May 28, 2020

@plippe
Copy link
Contributor Author

plippe commented May 28, 2020

I don't believe I am doing the "right" thing here. I was expecting some tests to fail locally.
I will have a deeper look tomorrow.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps for kicking this off!

@@ -280,19 +280,6 @@ impl<State> Request<State> {
.parse()
}

/// Get the URL querystring.
pub fn query<T: serde::de::DeserializeOwned>(&self) -> crate::Result<T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this method, but it should forward to self.req.query instead.

@yoshuawuyts yoshuawuyts merged commit 17b1c5e into http-rs:master May 29, 2020
@plippe plippe deleted the use-query-from-http-types branch May 30, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants