Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert #564

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Convert #564

merged 3 commits into from
Jun 3, 2020

Conversation

yoshuawuyts
Copy link
Member

@yoshuawuyts yoshuawuyts commented Jun 1, 2020 •
edited
Loading

I noticed we were exporting serde_json as-is after merging #523. This copies the approach in http-types and exports it as part of a convert submodule instead. Thanks!

edit: also added more of serde to the prelude.

@yoshuawuyts yoshuawuyts merged commit 049787a into master Jun 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the convert branch June 3, 2020 07:48
@jbr jbr mentioned this pull request Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshuawuyts @Fishrock123