Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SSE unwrap #588

Merged
merged 1 commit into from
Jun 12, 2020
Merged

fix SSE unwrap #588

merged 1 commit into from
Jun 12, 2020

Conversation

yoshuawuyts
Copy link
Member

Reported in https://twitter.com/fasterthanlime/status/1271398187484491776

Co-Authored-By: Amos Wenger <fasterthanlime@users.noreply.github.com>
@yoshuawuyts
Copy link
Member Author

Fixing CI in #589. Once that passes we should re-run CI here.

@yoshuawuyts
Copy link
Member Author

Okay, quite convinced this is an issue with crates.io, GitHub Actions, or the interaction between them. I can't reproduce this locally with either Windows or Linux; so just going to pray this passes.

Merging this!

@yoshuawuyts yoshuawuyts merged commit 1858cc0 into master Jun 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-sse-unwrap branch June 12, 2020 12:04
@fasterthanlime
Copy link
Contributor

fasterthanlime commented Jun 12, 2020

@yoshuawuyts note that there's another insert_header in upgrade

edit: that's the one you fixed - there's another one in endpoint, here:

res.res.insert_header("Cache-Control", "no-cache").unwrap();

yoshuawuyts added a commit that referenced this pull request Jun 12, 2020
Follow-up to #588, covers a case we missed.

Co-Authored-By: Amos Wenger <fasterthanlime@users.noreply.github.com>
This was referenced Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants