return a result from sse sender #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
force-pushed
the
handle-dropped-sse-encoder
branch
from
b233a66
to
276c5ef
Compare
jbr
added
bug
|
This is now blocked on an async-sse release (which I think is a major release because this changes the api) |
in order to allow endpoints to break out of loops
jbr
force-pushed
the
handle-dropped-sse-encoder
branch
from
276c5ef
to
88b0cbb
Compare
|
Merging this because async-sse 3.0.1 was published, breaking tide master (and tide 0.11). We'll probably want to yank async-sse 3.0.1 and republish as 4.0.0, which will require bumping tide's dep on master to async-sse 4.0.0, but merging this will fix tide master CI |
|
@jbr thanks for catching that and running the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to allow endpoints to break out of loops
dependent on: http-rs/async-sse#3
closes #591