Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: consistency improvements #651

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

Fishrock123
Copy link
Member

This is just a general pass of edits for the examples, for consistency and usability.

  • Use #[async_std::main]
  • Use tide::log::start();
  • Declare more in use.
  • Improved error_handling example.
  • GraphQL example now uses lazy_static!

Plus more misc minor nits.

This is just a general pass of edits for the examples, for consistency and usability.

- Use `#[async_std::main]`
- Use `tide::log::start();`
- Declare more in `use`.
- Improved `error_handling` example.
- GraphQL example now uses `lazy_static!`

Plus more misc minor nits.
Copy link
Member

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 improvements all around!

@Fishrock123 Fishrock123 merged commit 70cc76b into http-rs:master Jul 20, 2020
@Fishrock123 Fishrock123 deleted the examples-edits branch July 20, 2020 19:17
Fishrock123 added a commit to Fishrock123/tide that referenced this pull request Jul 21, 2020
Fishrock123 added a commit to Fishrock123/tide that referenced this pull request Jul 21, 2020
jbr pushed a commit that referenced this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants