Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce dependencies when cookies not enabled #780

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Reduce dependencies when cookies not enabled #780

merged 1 commit into from
Jan 28, 2021

Conversation

joshtriplett
Copy link
Member

Upgrade to http-types 2.10 with optional support for cookies, and make
use of that support to reduce dependencies.

yoshuawuyts
yoshuawuyts reviewed Jan 23, 2021
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@joshtriplett
Reduce dependencies when cookies not enabled
590d398 
Upgrade to http-types 2.10 with optional support for cookies, and make
use of that support to reduce dependencies.
@joshtriplett
Copy link
Member Author

Updated to ensure Body::from_file still works, which requires the fs feature of http-types. Right now, that feature is being enabled by other crates in the dependency tree, but since tide uses it directly, tide should depend on it.

@joshtriplett joshtriplett merged commit 50ab906 into http-rs:main Jan 28, 2021
@joshtriplett joshtriplett deleted the optional-cookies branch January 28, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts left review comments

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshtriplett @Fishrock123 @yoshuawuyts