Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing serde requirement in example #782

Merged
merged 1 commit into from
Jan 27, 2021
Merged

docs: Add missing serde requirement in example #782

merged 1 commit into from
Jan 27, 2021

Conversation

Stranger6667
Copy link
Contributor

Hello :)

First of all, thank you for creating and maintaining this crate. I enjoy it :)

This PR fixes the documentation for the "Getting started" example inside lib.rs. Without serde in dependencies, the compiler throws the following error:

error[E0463]: can't find crate for `serde`
 --> src/main.rs:5:17
  |
5 | #[derive(Debug, Deserialize)]
  |                 ^^^^^^^^^^^ can't find crate
  |
  = note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error

I noted that the similar example in README has serde in place and copied it here :)

@Fishrock123 Fishrock123 merged commit 3e27aa2 into http-rs:main Jan 27, 2021
@Fishrock123
Copy link
Member

Thanks for catching this!

@Stranger6667 Stranger6667 deleted the dd/fix-example-requirements branch January 27, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants