Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ross A. Baker <ross@rossabaker.com>
  • Loading branch information
hamnis and rossabaker authored Nov 7, 2024
1 parent 02e6f98 commit e765c72
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import org.typelevel.log4cats.noop.NoOpFactory
// Run e.g. with `bloop run core-test --args -J-Xmx200M`
object BodyLeakExample extends IOApp {

implicit val loggerFactor: LoggerFactory[IO] = NoOpFactory[IO]
implicit val loggerFactory: LoggerFactory[IO] = NoOpFactory[IO]

val app: HttpApp[IO] =
Kleisli((_: Request[IO]) => IO.pure(Response[IO]().withEntity("Hello, HTTP")))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import scala.concurrent.duration._
final class CompletableFutureTerminationTest extends CatsEffectSuite {
import CompletableFutureTerminationTest._

implicit val loggerFactor: LoggerFactory[IO] = NoOpFactory[IO]
implicit val loggerFactory: LoggerFactory[IO] = NoOpFactory[IO]

private val duration: FiniteDuration =
FiniteDuration(50L, TimeUnit.MILLISECONDS)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import scala.concurrent.duration._

class JdkWSClientSpec extends CatsEffectSuite {

implicit val loggerFactor: LoggerFactory[IO] = NoOpFactory[IO]
implicit val loggerFactory: LoggerFactory[IO] = NoOpFactory[IO]

val webSocket: IOFixture[WSClient[IO]] =
ResourceSuiteLocalFixture("webSocket", Resource.eval(JdkWSClient.simple[IO]))
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ import com.comcast.ip4s._
import org.typelevel.log4cats.LoggerFactory
import org.typelevel.log4cats.noop.NoOpFactory

implicit val loggerFactor: LoggerFactory[IO] = NoOpFactory[IO]
implicit val loggerFactory: LoggerFactory[IO] = NoOpFactory[IO]

val echoServer = EmberServerBuilder.default[IO]
.withPort(port"0")
Expand Down

0 comments on commit e765c72

Please sign in to comment.