Migrate to sbt-typelevel and self-host #120

armanbilge · 2022-01-08T06:05:48Z

Some comments below.

armanbilge · 2022-01-08T06:08:27Z

core/src/main/scala/org/http4s/sbt/Http4sOrgPlugin.scala

+          List("doc"),
+          name = Some("Build docs"),
+          cond = Some("matrix.ci == '' || matrix.ci == 'ciJVM'")),


So, this cond here is a bit annoying.

I don't quite understand it.

I'm trying to account for CI matrices with a JVM/JS axis here. There might be a better way to do this.

We only want to run doc once per platform, but we don't know if there are platforms and if so how they are setup. E.g. we might want to do project rootJVM; doc and project rootJS; doc in their appropriate jobs. But that seems hard, since not all project have rootJVM and rootJS.

So, what I did was try to run doc conditionally:

matrix.ci == 'ciJVM' we are running in a JVM job in a crossed matrix, so we should run doc

matrix.ci == '' The ci key is not defined, so the matrix is not crossed, and we should run doc

Of course, we could run this step on all the jobs, but it would be redundant and time-consuming.

Fixing typelevel/sbt-typelevel#61 would fix this insanity.

armanbilge · 2022-01-08T06:08:56Z

core/src/main/scala/org/http4s/sbt/Http4sOrgPlugin.scala

      githubWorkflowBuildMatrixFailFast := Some(false),
-      githubWorkflowArtifactUpload := false,


Any reason we don't like this?

I remember it being an irritant, but don't remember why. I'm happy to try without it.

armanbilge · 2022-01-08T06:10:40Z

core/src/main/scala/org/http4s/sbt/Http4sOrgPlugin.scala

-          List("unusedCompileDependenciesTest"),
-          name = Some("Check unused compile dependencies")),


This is something not currently covered in sbt-typelevel. I'm a bit confused, are projects actually using this? If so I should add it back.

http4s should be. I think it's good POM hygiene, but it's one of my less popular opinions.

I've never used it but seems like a good idea. I don't see it in the http4s CI rn:
https://github.com/http4s/http4s/blob/0671d49d246639e3edad89d7f8e1ba979d9a7658/.github/workflows/ci.yml#L100-L125

We had the explicit dependencies check in addition to the unused dependencies check. The former was very controversial, but I'd like to reinstate the latter.

rossabaker

Maybe it's good to have a common org shim as we think about the Great Schism, but this plugin has shrunk to the point that I question whether it's still useful... which is a good thing.

rossabaker · 2022-01-09T03:09:26Z

.github/workflows/ci.yml

-
-      - name: Run tests
-        run: sbt ++${{ matrix.scala }} test
+      - run: sbt ++${{ matrix.scala }} ci


Now that I see it from a workflow perspective, I'm not sure I consider this progress. It is now harder to see on what step a build fails.

Opened typelevel/sbt-typelevel#60 to think about this one.

rossabaker · 2022-01-09T03:13:56Z

core/src/main/scala/org/http4s/sbt/Http4sOrgPlugin.scala

-          List("unusedCompileDependenciesTest"),
-          name = Some("Check unused compile dependencies")),


http4s should be. I think it's good POM hygiene, but it's one of my less popular opinions.

rossabaker · 2022-01-09T03:14:29Z

core/src/main/scala/org/http4s/sbt/Http4sOrgPlugin.scala

+          List("doc"),
+          name = Some("Build docs"),
+          cond = Some("matrix.ci == '' || matrix.ci == 'ciJVM'")),


I don't quite understand it.

armanbilge · 2022-01-09T05:08:11Z

but this plugin has shrunk to the point that I question whether it's still useful

We should possibly upstream more stuff from http4s proper to here, for example the laika config. I've currently duplicated it in the http4s-dom build to keep the theme consistent.

rossabaker · 2022-01-09T20:50:54Z

Yeah, site configs are one of the last remaining big chunks in the modern g8 templates. I'd love to see an easy way to start a Laika site, and encourage that in new project templates.

armanbilge · 2022-01-10T00:13:21Z

I think I heard of this happening to someone once, and it's baffling. Edit: here maybe: http4s/http4s#5313 (comment).

[error]       - name: Check headers
[error]                     ^ (different character)

armanbilge · 2022-01-10T00:19:15Z

Oh, I know what's going on: non-determinism in the order settings are enabled actually. Seems to be causing the headers and formatting checks to swap around?

armanbilge · 2022-01-10T00:55:49Z

I wonder if it's related to the version of sbt installed on the system (not defined in the build.properties). Because it seems to be deterministic/consistent across runs per machine, just different across machines.

The GH runner ships with sbt 1.5.7 (according to this) and my other local where I fixed the workflow has sbt 1.5.0 installed. My dev machine has 1.6.1 on it.

Edit: nope, not this.

rossabaker · 2022-01-10T02:28:14Z

WTF. Is that not an ordered collection in the GitHub plugin?

armanbilge · 2022-01-10T02:32:06Z

It is, but it's updated ~= by multiple plugins. So maybe the order in which that happens can change somehow...

https://github.com/typelevel/sbt-typelevel/blob/72370cafa09fb96d528771f4552acc26c3bef01b/ci-header/src/main/scala/org/typelevel/sbt/TypelevelCiHeaderPlugin.scala#L31

https://github.com/typelevel/sbt-typelevel/blob/72370cafa09fb96d528771f4552acc26c3bef01b/ci-format/src/main/scala/org/typelevel/sbt/TypelevelCiFormatPlugin.scala#L31

rossabaker · 2022-01-10T04:03:46Z

Oh, yikes. I don't know how to linearize that without one plugin knowing about the other.

Those plugins don't really do much. I wouldn't mind if these were baked into the opinionated Typelevel plugin, and anybody who doesn't want them can filter the steps, override the tasks, or just use the lower level plugin.

armanbilge · 2022-01-10T04:18:24Z

Yep, I got a bit too ambitious there with all the separate plugins. Too much pain for little gain. It's already plenty flexible.

armanbilge · 2022-01-17T00:39:27Z

I think this is ready.

armanbilge added 2 commits January 8, 2022 06:04

Migrate to sbt-typelevel, self-host

3b59fc1

Regenerate workflow

582773e

armanbilge commented Jan 8, 2022

View reviewed changes

Remove unused import

a52a20c

armanbilge mentioned this pull request Jan 8, 2022

v0.4.0 typelevel/sbt-typelevel#33

Closed

2 tasks

rossabaker reviewed Jan 9, 2022

View reviewed changes

armanbilge mentioned this pull request Jan 9, 2022

Should the single ci command alias be split into multiple workflow steps? typelevel/sbt-typelevel#60

Closed

armanbilge added 5 commits January 9, 2022 23:56

Bump sbt-typelevel snapshot

3bac380

Add ExplicitDepsPlugin to requires

4d1bed0

Try again?

25ea50b

Remove workflows

64de78c

Regenerate workflows

d11644b

armanbilge added 2 commits January 9, 2022 16:19

Regenerate workflow

8e725b7

Unused import

c627f3d

armanbilge mentioned this pull request Jan 10, 2022

Split CI into multiple steps typelevel/sbt-typelevel#65

Merged

armanbilge linked an issue Jan 10, 2022 that may be closed by this pull request

Create default matrix exclusions #110

Closed

armanbilge mentioned this pull request Jan 10, 2022

What else belongs in sbt-http4s-org? #121

Closed

4 tasks

Bump sbt-typelevel snapshot

3249508

armanbilge mentioned this pull request Jan 10, 2022

non-determinism from conflicting AutoPlugins sbt/sbt#1875

Closed

Bump sbt-typelevel

b1f2429

armanbilge requested a review from rossabaker January 17, 2022 00:39

rossabaker merged commit 3d8be9e into http4s:main Jan 18, 2022

armanbilge mentioned this pull request Apr 7, 2022

Proposal: move sbt-scalafmt to the TypelevelKernelPlugin typelevel/sbt-typelevel#247

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to sbt-typelevel and self-host #120

Migrate to sbt-typelevel and self-host #120

armanbilge commented Jan 8, 2022

armanbilge Jan 8, 2022

rossabaker Jan 9, 2022

armanbilge Jan 9, 2022

armanbilge Jan 9, 2022

armanbilge Jan 8, 2022

rossabaker Jan 9, 2022

armanbilge Jan 8, 2022

rossabaker Jan 9, 2022

armanbilge Jan 9, 2022

rossabaker Jan 9, 2022

rossabaker left a comment

rossabaker Jan 9, 2022

armanbilge Jan 9, 2022 •

edited

Loading

rossabaker Jan 9, 2022

rossabaker Jan 9, 2022

armanbilge commented Jan 9, 2022

rossabaker commented Jan 9, 2022

armanbilge commented Jan 10, 2022 •

edited

Loading

armanbilge commented Jan 10, 2022

armanbilge commented Jan 10, 2022 •

edited

Loading

rossabaker commented Jan 10, 2022

armanbilge commented Jan 10, 2022

rossabaker commented Jan 10, 2022

armanbilge commented Jan 10, 2022

armanbilge commented Jan 17, 2022

		githubWorkflowBuildMatrixFailFast := Some(false),
		githubWorkflowArtifactUpload := false,

		List("unusedCompileDependenciesTest"),
		name = Some("Check unused compile dependencies")),

Migrate to sbt-typelevel and self-host #120

Migrate to sbt-typelevel and self-host #120

Conversation

armanbilge commented Jan 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rossabaker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

armanbilge Jan 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

armanbilge commented Jan 9, 2022

rossabaker commented Jan 9, 2022

armanbilge commented Jan 10, 2022 • edited Loading

armanbilge commented Jan 10, 2022

armanbilge commented Jan 10, 2022 • edited Loading

rossabaker commented Jan 10, 2022

armanbilge commented Jan 10, 2022

rossabaker commented Jan 10, 2022

armanbilge commented Jan 10, 2022

armanbilge commented Jan 17, 2022

armanbilge Jan 9, 2022 •

edited

Loading

armanbilge commented Jan 10, 2022 •

edited

Loading

armanbilge commented Jan 10, 2022 •

edited

Loading