Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send Content-Length for OPTIONS requests when there is no data #1319

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

isidentical
Copy link
Contributor

Fixes #1310.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1319 (4af6030) into master (4d7d6b6) will decrease coverage by 0.51%.
The diff coverage is 95.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
- Coverage   97.28%   96.76%   -0.52%     
==========================================
  Files          67       93      +26     
  Lines        4235     6716    +2481     
==========================================
+ Hits         4120     6499    +2379     
- Misses        115      217     +102     
Impacted Files Coverage Δ
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 31.11% <27.90%> (-68.89%) ⬇️
tests/conftest.py 77.14% <61.53%> (-9.82%) ⬇️
httpie/manager/__main__.py 82.35% <82.35%> (ø)
httpie/output/lexers/metadata.py 82.35% <82.35%> (ø)
httpie/output/lexers/http.py 86.36% <86.36%> (ø)
tests/test_ssl.py 92.66% <87.50%> (-2.28%) ⬇️
httpie/models.py 95.19% <90.00%> (-2.18%) ⬇️
httpie/manager/tasks.py 90.41% <90.41%> (ø)
tests/test_uploads.py 97.70% <92.59%> (-2.30%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5288f0...4af6030. Read the comment docs.

@jkbrzt jkbrzt merged commit 33ea977 into httpie:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Length sent for OPTIONS requests
3 participants