-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra_site_dirs config option to solve #566 #701
Conversation
…not finding pip installed plugins (#566).
@@ -84,7 +84,8 @@ class Config(BaseConfigDict): | |||
about = 'HTTPie configuration file' | |||
|
|||
DEFAULTS = { | |||
'default_options': [] | |||
'default_options': [], | |||
'extra_site_dirs': [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could detect when running in a Homebrew installation and set extra_site_dirs
here to a useful default such as the example in README.rst
. I'm not sure if it's a good idea.
@matthew16550 thanks for the PR. I think it's a really good idea. I'll review it thoroughly when i have the time. |
# Conflicts: # httpie/core.py
# Conflicts: # httpie/core.py
Hi @jakubroztocil is this still relevant? I haven't been paying any attention here. If yes then I'd be happy to update the PR. |
@matthew16550 thanks for the PR and for coming back! Yes, it is still relevant. Let me look through the old solution in the coming days and share my thoughts. |
Thanks for your contribution @matthew16550, we decided to solve this problem similarly but in a different fashion in #1200. Closing in favour of that! |
Hi, it's my first contribution to HTTPie. Thanks for making a really great tool!
This is a possible solution for #566 by letting users specify extra directories for
sys.path
.