Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra_site_dirs config option to solve #566 #701

Closed
wants to merge 8 commits into from
Closed

Add extra_site_dirs config option to solve #566 #701

wants to merge 8 commits into from

Conversation

matthew16550
Copy link
Contributor

Hi, it's my first contribution to HTTPie. Thanks for making a really great tool!

This is a possible solution for #566 by letting users specify extra directories for sys.path.

@@ -84,7 +84,8 @@ class Config(BaseConfigDict):
about = 'HTTPie configuration file'

DEFAULTS = {
'default_options': []
'default_options': [],
'extra_site_dirs': [],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could detect when running in a Homebrew installation and set extra_site_dirs here to a useful default such as the example in README.rst. I'm not sure if it's a good idea.

@coveralls
Copy link

coveralls commented Sep 6, 2018

Coverage Status

Coverage increased (+0.2%) to 93.737% when pulling d6b4080 on matthew16550:add-extra-site-dirs into c591a38 on jakubroztocil:master.

@jkbrzt
Copy link
Member

jkbrzt commented Nov 24, 2018

@matthew16550 thanks for the PR. I think it's a really good idea. I'll review it thoroughly when i have the time.

@matthew16550
Copy link
Contributor Author

Hi @jakubroztocil is this still relevant? I haven't been paying any attention here.

If yes then I'd be happy to update the PR.

@jkbrzt
Copy link
Member

jkbrzt commented Mar 18, 2021

@matthew16550 thanks for the PR and for coming back! Yes, it is still relevant. Let me look through the old solution in the coming days and share my thoughts.

@isidentical
Copy link
Contributor

Thanks for your contribution @matthew16550, we decided to solve this problem similarly but in a different fashion in #1200. Closing in favour of that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants