Fix notice box styles #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this look on mobile devices? I still think the icon should stay on top for small screens. |
|
It's not on top. Actually it is the same as it is on Stackoverflow. AO with PR:
SO:
Instead of placing the icon on top, i would suggest to reduce the font size a little. SO also has a smaller font size. In most cases it's just a static notice anyways. Would that be ok? |
|
Haha sorry, completely forgot about this PR. Looks good though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more style to the notice box. It looks odd currently.
Before PR:
After PR:
Example taken from: https://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php?rq=1