Fix immutable strings manipulation

httprb · Jan 17, 2017 · e165f41 · e165f41
1 parent 149c1f8
commit e165f41
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/http/form_data/multipart.rb b/lib/http/form_data/multipart.rb
@@ -11,7 +11,7 @@ class Multipart
       # @param [#to_h, Hash] data form data key-value Hash
       def initialize(data)
         @parts          = Param.coerce FormData.ensure_hash data
-        @boundary       = ("-" * 21) << SecureRandom.hex(21)
+        @boundary       = (Array.new(21, "-") << SecureRandom.hex(21)).join("")
         @content_length = nil
       end
 

diff --git a/lib/http/form_data/multipart/param.rb b/lib/http/form_data/multipart/param.rb
@@ -5,19 +5,19 @@ module FormData
     class Multipart
       # Utility class to represent multi-part chunks
       class Param
+        CONTENT_DISPOSITION = ""
+
         # @param [#to_s] name
         # @param [FormData::File, #to_s] value
         def initialize(name, value)
-          @name = name.to_s
-          @value = value
-
+          @name   = name.to_s
+          @value  = value
           @header = "Content-Disposition: form-data; name=#{@name.inspect}"
 
           return unless file?
 
-          @header << "; filename=#{value.filename.inspect}"
-          @header << CRLF
-          @header << "Content-Type: #{value.mime_type}"
+          @header = "#{@header}; filename=#{value.filename.inspect}#{CRLF}" \
+                    "Content-Type: #{value.mime_type}"
         end
 
         # Returns body part with headers and data.