Make HttpServer an open class for customization #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn `HttpServer` into an open class to allow for slightly more customization than the `middleware` property allows. For my particular use case, I'm trying to add some simple logging, which would be an easy thing to do if I could just put a small wrapper around `dispatch`. I only made the `dispatch` method open here, since it seems like an obviously good customization point that would need inheritance instead of containment to customize.
tomieq
pushed a commit
to tomieq/swifterfork
that referenced
this pull request
Apr 1, 2021
Make HttpServer an open class for customization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn
HttpServerinto an open class to allow for slightly morecustomization than the
middlewareproperty allows.For my particular use case, I'm trying to add some simple logging, which
would be an easy thing to do if I could just put a small wrapper around
dispatch.I only made the
dispatchmethod open here, since it seems like anobviously good customization point that would need inheritance instead
of containment to customize.