Improved performance of reading #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
till0xff
commented
May 25, 2021
|
|
||
| let bytesRead = try read(into: &buffer, length: length) | ||
|
|
||
| let rv = [UInt8](buffer[0..<bytesRead]) |
There was a problem hiding this comment.
This line could run up to 25 seconds for length = 6 mb
|
@till0xff Could you update the CHANGELOG.md file. |
till0xff
force-pushed
the
speedup-large-file-upload
branch
from
34541e5 to
8e49e56
Compare
till0xff
force-pushed
the
speedup-large-file-upload
branch
from
5f1dcef to
ef326c4
Compare
|
@michaelenger done |
michaelenger
approved these changes
Oct 1, 2021
|
Sorry for the delays guys, merging this. It will come in the next release for sure. Thanks for this @till0xff |
tomieq
added a commit
to tomieq/swifterfork
that referenced
this pull request
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.