Rename Example to SwifterExample #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please merge this as it is blocking our project build as well. |
|
Same story here @elusivestudio. For now we are pointing to the fork I have made for this PR. |
michaelenger
reviewed
Sep 2, 2021
Xcode/Sources/HttpServerIO.swift
Outdated
| @@ -8,7 +8,7 @@ | |||
| import Foundation | |||
| import Dispatch | |||
|
|
|||
| public protocol HttpServerIODelegate: class { | |||
| public protocol HttpServerIODelegate: AnyObject { | |||
There was a problem hiding this comment.
This is a necessary change, but is unrelated to the renaming of the example directory. Could you please remove this from the PR?
fortmarek
force-pushed
the
stable
branch
2 times, most recently
from
fb81090
to
18fdf45
Compare
🎉 I can't merge this, however, so if someone who has enough right could do it, that'd be great 👌 |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Resolution of packages fails when any two packages have the same product. That's why having an
Examplewithout aSwifterprefix can quickly lead to conflicts with other packages.In this PR, I'd like to resolve that by renaming
ExampletoSwifterExample.