Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added custom headers into .ok response #500

Merged
merged 4 commits into from
Sep 20, 2021
Merged

added custom headers into .ok response #500

merged 4 commits into from
Sep 20, 2021

Conversation

yuri-qualtie
Copy link
Contributor

PR is implementation proposal for #496

@michaelenger
Copy link
Contributor

I like this change, but is it an idea to make custom headers available to the other response types (not found, for example) as well?

@yuri-qualtie
Copy link
Contributor Author

I like this change, but is it an idea to make custom headers available to the other response types (not found, for example) as well?

Maybe it could be done later. To my mind, currently custom headers are useful for .ok responses

@michaelenger
Copy link
Contributor

I forgot to mention that you should update the CHANGELOG with your change. You can find it at CHANGELOG.md.

@yuri-qualtie
Copy link
Contributor Author

I forgot to mention that you should update the CHANGELOG with your change. You can find it at CHANGELOG.md.

Done @michaelenger

@Vkt0r Vkt0r merged commit c9bf600 into httpswift:stable Sep 20, 2021
@gabrieldonadel
Copy link

@Vkt0r, any change of release a new version of Swifter including this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelenger michaelenger michaelenger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuri-qualtie @michaelenger @gabrieldonadel @Vkt0r