Remove boundListener

[blakeembrey]

Following up from pillarjs/path-to-regexp#333, it appears some users are passing Express.js instances directly to this library. Express.js has a method called bind (from node.js require('http').METHODS) so this is not the native method. For a very long time this has basically been a noop because it does a return this, but recently an implicit string coercion was removed for all the app[METHODS] methods, so this line now causes an error.

Opening to start a discussion since issues are disabled.

[CLAassistant]

All committers have signed the CLA.

[pimterry]

Express shadows native fn.bind() on request listeners? That is surprising! I can imagine that might cause a few problems.

This logic here can't safely be removed unfortunately - as described in the comment there, we need to ensure that within the 'request' event listener, this refers to the server you're listening to (and conceptually here that's httpolyglot, not the otherwise-invisible internal server instances). Dropping that will break various listener patterns elsewhere.

Should be an easy fix though - can you update this to use Function.prototype.bind instead, with a comment to explain why?

Looks like CI is failing due to unrelated type changes elsewhere - I'll sort that shortly, don't worry about it CI is failing due to type issues from this PRs change actually, the previous types can just be restored once we're using the prototype method directly instead.

[blakeembrey]

@pimterry Updated. For any express server this line has not worked to bind a function and just returned this. It's probably not too widespread in other frameworks, directly generating methods from http.METHODS feels like something that should be avoided.

[pimterry]

Thanks @blakeembrey! Merged & released as v2.2.2.