Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 4.2 (comment 4) #1030

Closed
mnot opened this issue Mar 22, 2022 · 2 comments · Fixed by #1074
Closed

Section 4.2 (comment 4) #1030

mnot opened this issue Mar 22, 2022 · 2 comments · Fixed by #1074
Labels

Comments

@mnot
Copy link
Member

mnot commented Mar 22, 2022

Section 4.2: We had trouble parsing this sentence.
Is a word missing? If neither suggestion below is correct, please
clarify what "any frame carrying ... SETTINGS" refers to.

Original:

 A frame size error in a frame that could alter
 the state of the entire connection MUST be treated as a connection
 error ([Section 5.4.1](https://www.rfc-editor.org/authors/rfc9113.html#section-5.4.1)); this includes any frame carrying a field block
 ([Section 4.3](https://www.rfc-editor.org/authors/rfc9113.html#section-4.3)) (that is, HEADERS, PUSH_PROMISE, and CONTINUATION),
 SETTINGS, and any frame with a stream identifier of 0.

Suggestion #1 (... and a SETTINGS frame):
A frame size error in a frame that could alter
the state of the entire connection MUST be treated as a connection
error (Section 5.4.1); this includes any frame carrying a field block
(Section 4.3) (that is, HEADERS, PUSH_PROMISE, and CONTINUATION) and
a SETTINGS frame, and any frame with a stream identifier of 0.

Suggestion #2 (... or a SETTINGS frame):
A frame size error in a frame that could alter
the state of the entire connection MUST be treated as a connection
error (Section 5.4.1); this includes any frame carrying a field block
(Section 4.3) (that is, HEADERS, PUSH_PROMISE, and CONTINUATION) or
a SETTINGS frame, and any frame with a stream identifier of 0.

@mnot mnot added the auth48 label Mar 22, 2022
@Lukasa
Copy link
Collaborator

Lukasa commented Mar 22, 2022

Suggestion 1 is correct.

@martinthomson
Copy link
Collaborator

I think that the list structure is supposed to be... includes:

  • any frame carrying a field block (...),
  • a SETTINGS frame, and
  • any frame with a stream identifier of 0.

Which suggests option 3, in my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants