Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header continuation #50

Closed
martinthomson opened this issue Mar 11, 2013 · 3 comments · Fixed by #98
Closed

Header continuation #50

martinthomson opened this issue Mar 11, 2013 · 3 comments · Fixed by #98
Assignees
Labels

Comments

@martinthomson
Copy link
Collaborator

@grmocg suggested that his header compression (#2) would include the ability to continue header blocks across frames. We should track this as a separate issue.

Important consideration is the way that header blocks mutate session state (for header compression). Interleaving of continued header frames will cause issues if we don't address this.

We should also consider whether this is a general facility or not.

@ghost ghost assigned martinthomson Mar 11, 2013
@grmocg
Copy link
Contributor

grmocg commented Mar 11, 2013

I believe we should fix this by declaring that, if there is a continuation
happening, no new headers frame is allowed to be sent until the
continuation is finished.
It just gets too difficult to deal with otherwise.

On Mon, Mar 11, 2013 at 1:26 PM, martinthomson notifications@github.comwrote:

@grmocg https://github.com/grmocg suggested that his header compression
(#2 #2) would include the
ability to continue header blocks across frames. We should track this as a
separate issue.

Important consideration is the way that header blocks mutate session state
(for header compression). Interleaving of continued header frames will
cause issues if we don't address this.

We should also consider whether this is a general facility or not.


Reply to this email directly or view it on GitHubhttps://github.com//issues/50
.

@mnot
Copy link
Member

mnot commented Mar 18, 2013

To clarify - you mean that no headers frame on a different stream can be sent?

@grmocg
Copy link
Contributor

grmocg commented Mar 18, 2013

yes.

It isn't the only possible solution, but it is relatively simple and it
seems like it should be a rare enough case...
-=R

On Mon, Mar 18, 2013 at 2:14 AM, Mark Nottingham
notifications@github.comwrote:

To clarify - you mean that no headers frame on a different stream can be
sent?


Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-15040712
.

grmocg added a commit to grmocg/http2-spec that referenced this issue May 14, 2013
confusing.

Added a flag in the HEADERS frame for header continuations.

Added pointers in HEADERS+PRIORITY and PUSH_PROMISE which reference
the flags in the HEADERS frame.

This should resolve httpwg#50
@mnot mnot closed this as completed in #98 May 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants