-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Base to Alpine 3.8 #43
Conversation
* Update base image to Alpine 3.8 * Install s6 process manager directly * Upgraded BATS to 1.1.0 * Install syslog-ng for postfix logging to stdout
I have also ran this image in Docker directly, and on kubernetes 1.11.1 as a deployment, and confirmed it works as expected. More testing would be appreciated :) Copy of my own CI run to show it works:
|
These spam the console too much, so disable them.
Hello @riptidewave93 , I appreciate for your PR which can help us upgrade the alpine to the latest with the fix and other enhancements! And I have read your changes, it looks good to me. So before we could double check it before we merge it to the master branch, could you please find at least one reviewer to approve your PR for double checking? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected.
LGTM
Great, let's update the Please let me know if there are any issues with the latest code, and appreciate your contributions! @danxg87 @riptidewave93 |
Thanks @zixia, if any bugs are reported feel free to tag me in and I will do what I can to sort them out. 👍 |
Update Base to Alpine 3.8
This PR should resolve #39, and also updates everything to the latest and greatest tagged versions across the board.