Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of operations in Dockerfile #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bain3
Copy link

@bain3 bain3 commented Jan 7, 2023

Hi,
I was tinkering with the code a little and noticed that the Dockerfile could be optimized a little to take advantage of docker's caching.

I've split the run command so all the downloads should only depend on the requirements.txt file and not on the whole codebase.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Base: 93.93% // Head: 94.09% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (90b8e2f) compared to base (04bd859).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   93.93%   94.09%   +0.16%     
==========================================
  Files           6        8       +2     
  Lines         742      847     +105     
  Branches      132      154      +22     
==========================================
+ Hits          697      797     +100     
- Misses         31       34       +3     
- Partials       14       16       +2     
Impacted Files Coverage Δ
webssh/utils.py 97.97% <0.00%> (ø)
webssh/__init__.py 50.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants