Merge agent and agent policy #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamchzh
approved these changes
Nov 16, 2020
davidrusu
commented
Nov 16, 2020
Gamenot
requested review from
Gamenot,
junluo-huawei and
Adaickalavan
and removed request for
junluo-huawei and
Gamenot
davidrusu
force-pushed
the
merge-agent-and-agent-policy
branch
from
f59f6f6 to
993f5d0
Compare
JVillella
reviewed
Nov 17, 2020
| class AgentPolicy(Agent): | ||
| # we cannot use debtcollector here to signal deprecation because the wrapper object is | ||
| # not pickleable, instead we simply print. | ||
| print("[DEPRECATED] AgentPolicy has been replaced with `smarts.core.agent.Agent`") |
There was a problem hiding this comment.
log a warning (via global logger) vs a print?
JVillella
reviewed
Nov 17, 2020
| # the action_adapter and ensure the controller accepts | ||
| # the produced action. | ||
| del policy | ||
| print(f"[DEPRECATED] `perform_self_test` has been deprecated: {self}") |
JVillella
approved these changes
Nov 17, 2020
|
Nice changes :) |
davidrusu
force-pushed
the
merge-agent-and-agent-policy
branch
from
4afa6b9 to
1d877ef
Compare
davidrusu
force-pushed
the
merge-agent-and-agent-policy
branch
from
a3bf17d to
8fff537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges Agent + AgentPolicy. The motivation for this change is to simplify our API surface area before we take on heterogeneous agent computing directly in #75.
AgentPolicy and Agent were nearly identical classes, doesn't make sense to have both.
I've made sure to keep these changes backwards compatible. We print noisy messages to our users to switch to the
Agentclass if we detect old api useage, but from a functional point of view, things should just work with the old API as well.fixes #88