Fix Envision visualization issue in "near real time" mode #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ax elapsed time change to 100
saulfield
reviewed
Dec 2, 2022
| msInSec * (elapsed_times[0] - prevElapsedTime) - | ||
| (Date.now() - waitStartTime) | ||
| ); | ||
| let delt_elapsed_time_in_sec = msInSec * (elapsed_times[0] - prevElapsedTime); |
There was a problem hiding this comment.
This is in milliseconds I believe. Also, I think the style is snakeCase (even though not everything here follows it).
Suggested change
| let delt_elapsed_time_in_sec = msInSec * (elapsed_times[0] - prevElapsedTime); | |
| let deltaElapsedMs = msInSec * (elapsed_times[0] - prevElapsedTime); |
| ); | ||
| let delt_elapsed_time_in_sec = msInSec * (elapsed_times[0] - prevElapsedTime); | ||
| if (delt_elapsed_time_in_sec > 100) { | ||
| delt_elapsed_time_in_sec = 100 |
There was a problem hiding this comment.
After using Python, it's easy to forget about semicolons. Though not always necessary in js, they should be used to make sure statements stay separate from each other.
Suggested change
| delt_elapsed_time_in_sec = 100 | |
| delt_elapsed_time_in_sec = 100; |
Gamenot
requested changes
Dec 2, 2022
Gamenot
reviewed
Dec 6, 2022
| @@ -15,6 +15,8 @@ Copy and pasting the git commit messages is __NOT__ enough. | |||
| - Added new video record ultility using moviepy. | |||
| - Added distance check between bubble and vehicle to avoid generating unnecessary cursors. | |||
| - Added `ConfigurableZone` for `Zone` object to types which enable users to build bubble by providing coordinates of the polygon. | |||
| - Added "SMARTS Performance Benchmark" development tool for evaluating the simulation performance. | |||
There was a problem hiding this comment.
Where did this entry come from?
Gamenot
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.